[ovs-dev] [ovs-dev, 1/2] ofproto-dpif: Rename "recurse" to "indentation".

Ryan Moats rmoats at us.ibm.com
Thu Apr 21 14:02:46 UTC 2016


> --- Original Message ---
> The "recurse" member of struct xlate_in and struct xlate_ctx is used for
> two purposes: to determine the amount of indentation in "ofproto/trace"
> output and to limit the depth of recursion.  An upcoming commit will
> separate these tasks, and so in preparation this commit renames "recurse"
> to "indentation".
>
> Signed-off-by: Ben Pfaff <blp at ovn.org>

Ben, I appear to be getting an error when I try to compile this:

ofproto/ofproto-dpif-xlate.c:3292:13: error: too many arguments to function
'xlate_recursively'
             xlate_recursively(ctx, rule, table_id <= old_table_id);
             ^
ofproto/ofproto-dpif-xlate.c:3214:1: note: declared here
 xlate_recursively(struct xlate_ctx *ctx, struct rule_dpif *rule)

Checking the patch, I see where you add the line at 3292, but I don't see
where the
method signature gets changed...

I'm going to hold off on part 2 until we clear this part up...

Ryan Moats



More information about the dev mailing list