[ovs-dev] [PATCH RFC] ovn: Add support for DSCP marking

Ben Pfaff blp at ovn.org
Fri Apr 22 00:01:53 UTC 2016


On Fri, Apr 15, 2016 at 04:30:41PM +0530, bschanmu at redhat.com wrote:
> From: Babu Shanmugam <bschanmu at redhat.com>
> 
> Added an additional option 'dscp_code' for VMI Logica_Ports in addition to the
> ingress_policing_rate and burst in the OVN Northbound database.
> 
> Also in the controller, replaced the earlier approach of setting the rate and
> burst parameters in the Interface table with Port tables's qos parameter
> (using the default queue). In this patch, 'linux-htb' is used as a
> fixed Qos type.
> 
> Signed-off-by: Babu Shanmugam <bschanmu at redhat.com>


I think that this should be two patches, one for DSCP, one for the QoS
changes.

There are some style issues, such as lack of {} around single statements.

The DSCP feature seems fine to me.

Converting policing into shaping changes the semantics.  If these are
superior semantics (which does seem likely) then that's fine but it
needs documentation and rationale.



More information about the dev mailing list