[ovs-dev] [PATCH 2/2] ovn-controller: add local address for ovn-remote connection

[Ben Pfaff]

On Fri, Apr 22, 2016 at 03:51:57PM +0000, Huang, Lei wrote:
> 
> On 4/22/16, 11:21 PM, "dev on behalf of Ben Pfaff" <dev-bounces at openvswitch.org on behalf of blp at ovn.org> wrote:
> 
> >On Fri, Apr 22, 2016 at 04:14:25PM +0800, Huang Lei wrote:
> >> From: Huang Lei <lhuang8 at ebay.com>
> >> 
> >> Add a local address option for ovn-controller's TCP socket which
> >> connect to southbound ovsdb-server.
> >> 
> >> In a test environment, an interface may have multiple IP addresses
> >> in same subnet, if TCP client socket doesn't call bind() explicitly,
> >> OS chooses an ip and port for it, and the IP is the primary IP of
> >> the subnet on an interface. With this patch, a secondary IP of the
> >> subnet can be used as local address of TCP connection.
> >> 
> >> Signed-off-by: Huang Lei <lhuang8 at ebay.com>
> >
> >Why not just extend the syntax for streams to allow a local address (and
> >possibly local port) to be specified?
> >e.g. remote-ip:remote-port:local-ip:local-port.
> 
> Hmmm, so the possible values of ‘external-ids:ovn-remote’ will be as follow:
> external-ids:ovn-remote=tcp:192.168.0.1:6640:192.168.0.2:10000
> 
> external-ids:ovn-remote=tcp:192.168.0.1:6640:192.168.0.2
> 
> external-ids:ovn-remote=tcp:192.168.0.1:6640
> 
> 
> Right?

Yes; I think it should be possible to omit fields too:
        tcp:192.168.0.1::192.168.0.2:

It seems reasonable to me.  Well, maybe not reasonable per se, but
reasonable for the odd corner case where one really cares about the
local IP.