[ovs-dev] [PATCH] Add change tracking documentation

Ryan Moats rmoats at us.ibm.com
Fri Apr 22 21:23:32 UTC 2016


"Ansari, Shad" <shad.ansari at hpe.com> wrote on 04/22/2016 11:38:17 AM:

> From: "Ansari, Shad" <shad.ansari at hpe.com>
> To: Ryan Moats/Omaha/IBM at IBMUS, "dev at openvswitch.org"
<dev at openvswitch.org>
> Date: 04/22/2016 11:39 AM
> Subject: RE: [ovs-dev] [PATCH] Add change tracking documentation
>
>
> > +/* Change tracking.  In OVSDB, change tracking is applied at each
> > +client in
> > + * the IDL layer.  This means that when a client makes a request to
> > +track
> > + * changes on a particular table, they are essentially requesting
> > + * information about the incremental changes to that table from the
> > +point in
> > + * time that the request is made.  Once the client clears tracked
> > +changes,
> > + * that information will no longer be available.
>
> Suggestion: I would leave it at that. The implication you are
> deriving may not apply to all usages.

I don't quite agree with just leaving it there.  The fact is that
one *can't* replay past changes after they are cleared and so if
a client requires replaying the untracked past, it faces the difficult
choice of either trying to remember the changes itself (which I believe
translates into a memory leak), or having two independent code paths.

Now, I'm willing to move the statement beyond into a separate paragraph
and wordsmith it to the above, but I'm not comfortable with just
leaving it be at the above.

Ryan



More information about the dev mailing list