[ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

[Ryan Moats]

Russell Bryant <russell at ovn.org> wrote on 08/02/2016 12:00:08 PM:

> From: Russell Bryant <russell at ovn.org>
> To: Ben Pfaff <blp at ovn.org>
> Cc: Ryan Moats/Omaha/IBM at IBMUS, ovs dev <dev at openvswitch.org>
> Date: 08/02/2016 12:00 PM
> Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands
>
> On Tue, Aug 2, 2016 at 12:03 PM, Ben Pfaff <blp at ovn.org> wrote:
> On Tue, Aug 02, 2016 at 07:56:27AM -0400, Russell Bryant wrote:
> > On Tue, Aug 2, 2016 at 12:20 AM, Ryan Moats <rmoats at us.ibm.com> wrote:
> >
> > > This commit creates wrapper scripts for the *ctl commands to use
> > > --dry-run for those that have them, and to allow for log level
> > > setting via ovs-appctl without allowing full access to ovs-appctl.
> > > Tests have been added to make sure that the wrapper scripts
> > > don't actually do anything when asked to perform a write operation.
> > >
> > > Signed-off-by: Ryan Moats <rmoats at us.ibm.com>
> > >
> >
> > What's the motivation for all the new "read" scripts?  It seems a bit
> > confusing to install all of these.  They're also not documented
anywhere.
>
> My assumption had been that we'd put the options into the tree and then
> that the one-liner redirection scripts would be an IBM customization.
> After all, they need to customize somehow anyway to hide the read/write
> versions in some off-$PATH place.
>
> +1 to this approach.
>
> --
> Russell Bryant

Obviously, I think this is somewhat short-sighted (or I wouldn't have
proposed
the patch)...

How about if we were to spin a new repo openvswitch/operator-tools (like
openvswitch/ovn-scale-test)
and put things like this *there*?

Ryan