[ovs-dev] [PATCH V11 17/17] tests: Skip vlog tests that try to move opened file

[Guru Shetty]

On 2 August 2016 at 10:45, Paul Boca <pboca at cloudbasesolutions.com> wrote:

> On Windows if a file is opened by an application for writing, we cannot
> move
> it until all handles to that file are closed.
>
> Signed-off-by: Paul-Daniel Boca <pboca at cloudbasesolutions.com>
> Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
>

I skipped the patches till here (starting from the previously commented
patch) as they are not relevant as I skipped the daemonization patch. I
applied this one.


> ---
> V3: Initial commit
> V4: No changes
> V5: No changes
> V6: Removed code that disables 'vlog/close' tests.
> V7: Small comments changes
> V8: No changes
> V9: No changes
> V10: No changes
> V11: No changes
> ---
>  tests/vlog.at | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tests/vlog.at b/tests/vlog.at
> index 4907a1b..468e872 100644
> --- a/tests/vlog.at
> +++ b/tests/vlog.at
> @@ -148,6 +148,9 @@ AT_CLEANUP
>
>  m4_define([VLOG_REOPEN_PYN],
>    [AT_SETUP([vlog - vlog/reopen - $1])
> +   # This test won't work as-is on Windows because Windows doesn't allow
> +   # files that are open to be renamed.
> +   AT_SKIP_IF([test "$IS_WIN32" = "yes"])
>     AT_SKIP_IF([test $2 = no])
>     on_exit 'kill `cat test-unixctl.py.pid`'
>
> --
> 2.7.2.windows.1
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>