[ovs-dev] [RFC/PATCH v2] Make the PID part of socket path configurable

[Christian Svensson]

Thanks for the comments.

On Mon, Aug 8, 2016 at 6:29 PM, Ben Pfaff <blp at ovn.org> wrote:
>
> I don't think it's reasonable to make this a configuration-time option.
> I want Open vSwitch behavior to be fairly uniform at runtime, not
> unpredictable based on whatever flags were supplied at build time.
>

Isn't it already as rundir is configured exactly like this and behavior
(what to name the socket) is affected by it?
I agree it's not perfect, but I couldn't think of a better way of solving
this while still providing backwards compatibility.

Besides, it's not like it's dead code, it's just making the Linux platform
use the Window platform's logic for calculating the socket path.
In my opinion the side effect that the PID logic is configurable to be OS
agnostic is reason alone that this is a good change, but I'm obviously
biased.


> I suggest that you just use "--pidfile=<program>.pid" on the command
> line, instead.


Sorry, but how does that solve the problem? Maybe I'm missing something,
but that only activates the behavior to make socket paths resolvable
without globing.
The alternative I'm looking for would be something like
--unixctl=/run/openvswitch/my-daemon.ctl but that does not exist.

This particular use-case is for OpenSwitch. Having OpenvSwitch using PID
files would be the only service to do so, and we're faced with either
having --pidfile on every single daemon that uses OVSDB (a lot) or change
the compile time default.
Hopefully it makes sense why we want to avoid this complexity in our case.