[ovs-dev] [PATCH] ovn-controller:improve the ofctrl_run, pinctrl_run

[nickcooper-zhangtonghao]

> On Aug 7, 2016, at 5:44 AM, Ryan Moats <rmoats at us.ibm.com> wrote:
> 
> "dev" <dev-bounces at openvswitch.org> wrote on 08/04/2016 06:50:03 AM:
> 
> > From: nickcooper-zhangtonghao <nickcooper-zhangtonghao at opencloud.tech>
> > To: dev at openvswitch.org
> > Cc: nickcooper-zhangtonghao <nickcooper-zhangtonghao at opencloud.tech>
> > Date: 08/04/2016 06:50 AM
> > Subject: [ovs-dev] [PATCH] ovn-controller:improve the ofctrl_run, pinctrl_run
> > Sent by: "dev" <dev-bounces at openvswitch.org>
> > 
> > Before calling the function "ofctrl_run" and "pinctrl_run",
> > the "br-int"" has been checked. Remove the conditional statements in
> > the function may make the code clearer.
> > 
> > Signed-off-by: nickcooper-zhangtonghao <nickcooper-
> > zhangtonghao at opencloud.tech>
> > ---
> 
> This applies cleanly, it passes all the unit tests, and I understand
> the logic behind it, but I can't help but think it means we've missed
> something along the way... 
> 
> so, Reluctantly-Acked-by: Ryan Moats <rmoats at us.ibm.com>
> 
Thanks for your review. This patch makes only the codes clearer, and doesn’t make 
much sense.