[ovs-dev] [PATCH] ofproto-dpif-xlate: Fix VLOG_ERR_RL() call.

[Daniele Di Proietto]

2016-08-11 17:54 GMT-07:00 Joe Stringer <joe at ovn.org>:

> a716ef9a7a73 ("ofproto-dpif-xlate: Log flow in XLATE_REPORT_ERROR.")
> inadvertantly broke build on clang due to improper passing of the ds
> cstring into the VLOG() function:
>
> error: format string is not a string literal
>       (potentially insecure) [-Werror,-Wformat-security]
>         XLATE_REPORT_ERROR(ctx, "over max translation depth %d",
> MAX_DEPTH);
>         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~
> note: expanded from macro
>       'XLATE_REPORT_ERROR'
>             VLOG_ERR_RL(&error_report_rl, ds_cstr(&ds));        \
>
> Reported-by: Daniele Di Proietto <diproiettod at vmware.com>
> Signed-off-by: Joe Stringer <joe at ovn.org>
>

Thanks for fixing it. It works for me now

Acked-by: Daniele Di Proietto <diproiettod at vmware.com>