[ovs-dev] [PATCH] datapath: compat: keep skb mark across tunnel devices.

Joe Stringer joe at ovn.org
Fri Aug 12 05:33:18 UTC 2016


On 11 August 2016 at 19:43, Pravin B Shelar <pshelar at ovn.org> wrote:
> Older kernel skb_scrub_packet() has bug which resets skb mark for
> all packet. It is fixed during 3.18 release where it is reset
> only for packets crossing namespace. So OVS is forced to use
> compat skb_scrub_packet() on older kernel.
> This is related to upstream bug fix commit ca7c7b9059e3
> ("skbuff: Do not scrub skb mark within the same name space").
>
> VMware-BZ: #1710701
> Signed-off-by: Pravin B Shelar <pshelar at ovn.org>
> ---

This looks good to me, although the original upstream commit seems to
be in Linus' tree only from v4.1:
https://github.com/torvalds/linux/commit/213dd74aee765d4e5f3f4b9607fef0cf97faa2af

I guess it was backported to some kernel versions, but it would be
more consistent to use this number if in doubt.

Acked-by: Joe Stringer <joe at ovn.org>



More information about the dev mailing list