[ovs-dev] [PATCH rebase v7 2/2] DSCP marking on packets egressing VIF interface

Ben Pfaff blp at ovn.org
Sat Aug 13 19:12:26 UTC 2016


On Fri, Aug 12, 2016 at 12:21:28PM +0530, bschanmu at redhat.com wrote:
> From: Babu Shanmugam <bschanmu at redhat.com>
> 
> ovn-northd sets 'ip.dscp' to the DSCP value
> 
> Signed-off-by: Babu Shanmugam <bschanmu at redhat.com>

Thanks for the revision (and for adding a test)!

This comment in ovn-northd seems like an incomplete thought (and what's
a "packed"?  A packet?  A port?):

> +            /* If DSCP is enabled on this packed, add another flow at a higher */

The big comment on build_port_security_ip() should probably describe the
new behavior, as should ovn-northd(8).

The documentation talks about applying DSCP to packets egressing an
interface but build_port_security_ip() seems to actually apply DSCP to
packets ingressing an interface.

Thanks,

Ben.



More information about the dev mailing list