[ovs-dev] [PATCH] ovsdb-idl: Fix double-remove in ovsdb_idl_condition_reset().

Ben Pfaff blp at ovn.org
Sun Aug 14 00:37:54 UTC 2016


Both ovsdb_idl_condition_reset() and ovsdb_idl_clause_free() call
ovs_list_remove() on the clause's 'node' member, but it should only be
called once.

Signed-off-by: Ben Pfaff <blp at ovn.org>
---
 lib/ovsdb-idl.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 7d3d328..7da25a5 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -748,7 +748,6 @@ ovsdb_idl_condition_reset(struct ovsdb_idl *idl,
     struct ovsdb_idl_table *table = ovsdb_idl_table_from_class(idl, tc);
 
     LIST_FOR_EACH_SAFE (c, next, node, &table->condition.clauses) {
-        ovs_list_remove(&c->node);
         ovsdb_idl_clause_free(c);
     }
     idl->cond_changed = table->cond_changed = true;
-- 
2.1.3




More information about the dev mailing list