[ovs-dev] [PATCH v8 2/3] netdev-dummy: Add dummy-internal class.

Ben Pfaff blp at ovn.org
Mon Aug 15 03:12:14 UTC 2016


On Fri, Aug 12, 2016 at 07:56:54PM -0700, Daniele Di Proietto wrote:
> "internal" netdevs are treated specially in OVS (e.g. for MTU), but
> the dummy datapath remaps both "system" and "internal" devices to the
> same "dummy" netdev class, so there's no way to discern those in tests.
> 
> This commit adds a new "dummy-internal" netdev type, which will be used
> by the dummy datapath for internal ports, so that other parts of the
> code can understand which ports are internal just by looking at the
> netdev object.
> 
> The alternative solution, using the original interface type ("internal")
> instead of the translated netdev type ("dummy"), is harder to implement,
> because in so many places only the netdev object is available.
> 
> Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>

If the tests pass, I'm happy with this.

Acked-by: Ben Pfaff <blp at ovn.org>



More information about the dev mailing list