[ovs-dev] [PATCH v4 0/2] Read only versions of the *ctl commands
Ryan Moats
rmoats at us.ibm.com
Mon Aug 15 03:53:25 UTC 2016
This patch series adds read-only wrapper scripts around the various
*ctl commands that leverage the --dry-run command line option for
scripts that modify a database.
For commands that don't have the --dry-run option (ovs-dpctl
and ovs-ofctl) a new --read-only option is added to prevent commands
tagged as read/write from being executed.
Negative tests are included to verify that the wrapper scripts
don't change things.
v3->v4:
rebased
v2->v3:
Changed from --dry-run to --read-only for ovs-dpctl and ovs-ofctl
v1->v2:
Fixed typo in patch set one.
Added unit test for ovs-appsetlog
Added new scripts into approriate debian package definitions.
Ryan Moats (2):
Add read-only option to ovs-dpctl and ovs-ofctl commands.
Add wrapper scripts for *ctl commands
debian/openvswitch-common.install | 2 +
debian/openvswitch-switch.install | 2 +
debian/ovn-common.install | 2 +
lib/command-line.c | 51 ++++++++----
lib/command-line.h | 6 +-
lib/db-ctl-base.h | 2 +-
lib/dpctl.c | 47 ++++++-----
lib/dpctl.h | 3 +
ovn/utilities/automake.mk | 8 +-
ovn/utilities/ovn-nbread | 2 +
ovn/utilities/ovn-sbread | 2 +
ovsdb/ovsdb-tool.c | 28 +++----
tests/ovn-nbctl.at | 103 ++++++++++++++++++++++++
tests/ovn-sbctl.at | 46 +++++++++++
tests/ovs-ofctl.at | 43 ++++++++++
tests/ovs-vsctl.at | 90 +++++++++++++++++++++
tests/ovstest.c | 4 +-
tests/test-bitmap.c | 6 +-
tests/test-ccmap.c | 6 +-
tests/test-classifier.c | 28 +++----
tests/test-cmap.c | 6 +-
tests/test-conntrack.c | 6 +-
tests/test-heap.c | 14 ++--
tests/test-jsonrpc.c | 10 +--
tests/test-netlink-conntrack.c | 8 +-
tests/test-ovn.c | 26 +++----
tests/test-ovsdb.c | 80 +++++++++----------
tests/test-reconnect.c | 32 ++++----
tests/test-util.c | 34 ++++----
tests/test-vconn.c | 18 ++---
tests/vlog.at | 27 +++++++
tests/vtep-ctl.at | 145 ++++++++++++++++++++++++++++++++++
utilities/automake.mk | 10 ++-
utilities/ovs-appsetlog | 40 ++++++++++
utilities/ovs-dpctl.c | 7 ++
utilities/ovs-dpread | 2 +
utilities/ovs-ofctl.8.in | 3 +
utilities/ovs-ofctl.c | 160 +++++++++++++++++++++-----------------
utilities/ovs-ofread | 2 +
utilities/ovs-vsread | 2 +
vtep/automake.mk | 5 +-
vtep/vtep-read | 2 +
42 files changed, 853 insertions(+), 267 deletions(-)
create mode 100755 ovn/utilities/ovn-nbread
create mode 100755 ovn/utilities/ovn-sbread
create mode 100755 utilities/ovs-appsetlog
create mode 100755 utilities/ovs-dpread
create mode 100755 utilities/ovs-ofread
create mode 100755 utilities/ovs-vsread
create mode 100755 vtep/vtep-read
--
2.7.4
More information about the dev
mailing list