[ovs-dev] [PATCH 2/2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

pravin shelar pshelar at ovn.org
Mon Aug 15 16:58:55 UTC 2016


On Sat, Aug 13, 2016 at 10:11 AM, Jesse Gross <jesse at kernel.org> wrote:
> On Fri, Aug 12, 2016 at 10:49 AM, Pravin B Shelar <pshelar at ovn.org> wrote:
>> Upstream commit:
>>     commit 4b5b9ba553f9aa5f484ab972fc9b58061885ceca
>>     Author: Martynas Pumputis <martynas at weave.works>
>>     Date:   Tue Aug 9 16:24:50 2016 +0100
>>
>>     openvswitch: do not ignore netdev errors when creating tunnel vports
>>
>>     The creation of a tunnel vport (geneve, gre, vxlan) brings up a
>>     corresponding netdev, a multi-step operation which can fail.
>>
>>     For example, changing a vxlan vport's netdev state to 'up' binds the
>>     vport's socket to a UDP port - if the binding fails (e.g. due to the
>>     port being in use), the error is currently ignored giving the
>>     appearance that the tunnel vport creation completed successfully.
>>
>>     Signed-off-by: Martynas Pumputis <martynas at weave.works>
>>     Acked-by: Pravin B Shelar <pshelar at ovn.org>
>>     Signed-off-by: David S. Miller <davem at davemloft.net>
>>
>> Signed-off-by: Pravin B Shelar <pshelar at ovn.org>
>
> Should we also extend this to LISP and STT?
right, I missed it.
I posted upstream patch.



More information about the dev mailing list