[ovs-dev] [PATCH v5 4/8] meta-flow: New functions mf_subfield_copy() and mf_subfield_swap().

[Justin Pettit]

> On Aug 14, 2016, at 3:24 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> diff --git a/lib/meta-flow.c b/lib/meta-flow.c
> index 2c89613..a7d3131 100644
> --- a/lib/meta-flow.c
> +++ b/lib/meta-flow.c
> @@ -1962,6 +1962,80 @@ mf_check__(const struct mf_subfield *sf, const struct flow *flow,
>     }
> }
> 
> +/* Sets all the bits in 'sf' to 1 within 'wc', if 'wc' is nonnull. */
> +static void
> +unwildcard_subfield(const struct mf_subfield *sf, struct flow_wildcards *wc)

Good name!

> +/* Copies 'src' into 'dst' within 'flow', and sets all the bits in 'src' and
> + * 'dst to 1s in 'wc', if 'wc' is nonnull.
> + *
> + * 'src' and 'dst may overlap. */

I think you need to add "'" to two of the 'dst' strings.

> +/* Swaps the bits in 'src' and 'dst' within 'flow', and sets all the bits in
> + * 'src' and 'dst to 1s in 'wc', if 'wc' is nonnull.
> + *
> + * 'src' and 'dst may overlap. */

I think you need to add "'" to two of the 'dst' strings.

Acked-by: Justin Pettit <jpettit at ovn.org>

--Justin