[ovs-dev] [PATCH] ovn-northd: Remove unnecessary 'if' test from build_acls().

Ben Pfaff blp at ovn.org
Thu Aug 18 18:13:31 UTC 2016


On Thu, Aug 18, 2016 at 09:20:37AM +0530, Numan Siddique wrote:
> On Thu, Aug 18, 2016 at 3:19 AM, Ben Pfaff <blp at ovn.org> wrote:
> 
> > This 'if' statement checked for two conditions, but neither one was
> > necessary.  First, od->nbs is always nonnull, because the caller already
> > checked.  Second, it doesn't matter whether od->nbs->n_ports is nonzero
> > because it doesn't affect the behavior of the code protected by the 'if'
> > statement.
> >
> > This change is best viewed ignoring white space only changes.
> >
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > ---
> >
> 
> ​​
> 
> Thanks for correcting it.
> 
> ​Acked-by: Numan Siddique <nusiddiq at redhat.com>

Thanks, applied to master.



More information about the dev mailing list