[ovs-dev] [PATCH v4] ovn-controller: Back out incremental processing

Flavio Fernandes flavio at flaviof.com
Thu Aug 25 15:19:38 UTC 2016


> On Aug 24, 2016, at 9:30 PM, Ryan Moats <rmoats at us.ibm.com> wrote:
> 
> As [1] indicates, incremental processing hasn't resulted
> in an improvement worth the complexity it has added.
> This patch backs out all of the code specific to incremental
> processing, along with the persisting of OF flows,
> logical ports, multicast groups, all_lports, local and patched
> datapaths
> 
> [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
> 
> Signed-off-by: Ryan Moats <rmoats at us.ibm.com>
> Co-authored-by: Guru Shetty <guru at ovn.com>

Acked-by: Flavio Fernandes <flavio at flaviof.com>
Tested-by: Flavio Fernandes <flavio at flaviof.com>

> ---


I've loaded my 3 node test setup with these changes [1] and ensured that
flows/tables looked as expected [2].

[1]: https://github.com/flavio-fernandes/just-ovn-nodes/blob/5260f60ec7c82b1b030d79857fa2394e8a75a47a/scripts/tutorial/l3_basic/setup.sh
[2]: https://gist.github.com/a47d2f280cb153110931c90ddbbcec84
      https://gist.github.com/c8242cc1f736c26aea10fec68d9d51f8


> include/ovn/actions.h           |   4 -
> ovn/controller/binding.c        | 154 ++-----------------
> ovn/controller/binding.h        |   1 -
> ovn/controller/encaps.c         | 111 ++++++--------
> ovn/controller/lflow.c          | 102 ++++---------
> ovn/controller/lflow.h          |   4 +-
> ovn/controller/lport.c          | 220 +++++---------------------
> ovn/controller/lport.h          |  24 +--
> ovn/controller/ofctrl.c         | 331 +++++++++++-----------------------------
> ovn/controller/ofctrl.h         |  16 +-
> ovn/controller/ovn-controller.c |  60 +++++---
> ovn/controller/patch.c          |   6 -
> ovn/controller/physical.c       | 166 +++++---------------
> ovn/controller/physical.h       |   3 +-
> ovn/lib/actions.c               |   1 -
> tests/ovn.at                    |  55 +++++++
> 16 files changed, 353 insertions(+), 905 deletions(-)
> 




More information about the dev mailing list