[ovs-dev] [ovs-dev, v5] ovn-controller: Back out incremental processing

[Ben Pfaff]

On Fri, Aug 26, 2016 at 01:30:59PM +0000, Ryan Moats wrote:
> As [1] indicates, incremental processing hasn't resulted
> in an improvement worth the complexity it has added.
> This patch backs out all of the code specific to incremental
> processing, along with the persisting of OF flows,
> logical ports, multicast groups, all_lports, local and patched
> datapaths
> 
> [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html
> 
> Signed-off-by: Ryan Moats <rmoats at us.ibm.com>

Thanks for working on this.  I think that it is the best approach for
now.  I'm working on a few ideas about ways to build systematic and
reliable incremental update, but they won't be ready for 2.6.

There is still some incremental behavior in a few places.  I am not sure
whether this is intentional or if you just missed them.  Can you comment
on these?

  - Remaining _FOR_EACH_TRACKED usages in encaps_run().  Actually it's a
    little surprising that encaps still maintains static state, should
    it?

  - lflow.c has a persistent collection of address sets.

  - physical.c persists lots of state.

Thanks,

Ben.