[ovs-dev] [PATCH 09/12] python tests: Skip ovn-controller-vtep tests on Windows

Paul Boca pboca at cloudbasesolutions.com
Tue Aug 30 09:17:43 UTC 2016


Hi Guru,

The problem with ovn tests is that the ‘—detach’ is used for clients, which on Windows is
ignored.
For example here: https://github.com/openvswitch/ovs/blob/master/ovn/utilities/ovn-trace.c#L85
on Windows will always call https://github.com/openvswitch/ovs/blob/master/ovn/utilities/ovn-trace.c#L92-L93
instead of https://github.com/openvswitch/ovs/blob/master/ovn/utilities/ovn-trace.c#L87-L88. So this will raise
some errors in ovn tests on Windows.
I don’t know if ignoring the ‘—detach’ switch is intended or is a porting error.

Paul

From: Guru Shetty [mailto:guru at ovn.org]
Sent: Friday, August 26, 2016 9:07 PM
To: Paul Boca
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH 09/12] python tests: Skip ovn-controller-vtep tests on Windows



On 26 August 2016 at 07:40, Paul Boca <pboca at cloudbasesolutions.com<mailto:pboca at cloudbasesolutions.com>> wrote:
The tests are not intended to run on Windows.

Can you explain why? What part of the test gives a problem in Windows? Is it that the ovs-vtep.py has not been ported to Windows?

Until now they were skipped based on $HAVE_PYTHON only.

Signed-off-by: Paul-Daniel Boca <pboca at cloudbasesolutions.com<mailto:pboca at cloudbasesolutions.com>>
---
 tests/ovn-controller-vtep.at<http://ovn-controller-vtep.at> | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/ovn-controller-vtep.at<http://ovn-controller-vtep.at> b/tests/ovn-controller-vtep.at<http://ovn-controller-vtep.at>
index 654c212..3f024cb 100644
--- a/tests/ovn-controller-vtep.at<http://ovn-controller-vtep.at>
+++ b/tests/ovn-controller-vtep.at<http://ovn-controller-vtep.at>
@@ -15,7 +15,7 @@ m4_define([OVN_CONTROLLER_VTEP_START],
   [
    AT_KEYWORDS([ovn])
    # this will cause skip when 'make check' using Windows setup.
-   AT_SKIP_IF([test $HAVE_PYTHON = no])
+   AT_SKIP_IF([test "$IS_WIN32" = "yes"])

    dnl Create databases (ovn-nb, ovn-sb, vtep).
    AT_CHECK([ovsdb-tool create vswitchd.db $abs_top_srcdir/vswitchd/vswitch.ovsschema])
--
2.7.2.windows.1
_______________________________________________
dev mailing list
dev at openvswitch.org<mailto:dev at openvswitch.org>
http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list