[ovs-dev] [PATCH 2/2] ovs-ofctl: Extract tunnel metadata correctly when sorting flows.

Ben Pfaff blp at ovn.org
Tue Aug 30 22:24:46 UTC 2016


On Mon, Aug 29, 2016 at 11:58:15AM -0700, Jesse Gross wrote:
> When flow fields are sorted before dumping in ovs-ofctl, each
> significant field is extracted for sorting. However, in the case of
> tunnel metadata a mapping table is necessary to know where each
> field begins and ends. This information is current stripped off before
> fetching the field data and returned field is simply zeroed. This
> makes sorting based on tunnel metadata non-deterministic.
> 
> We have the tunnel allocation stored in match metadata with each
> flow, so we can simply extract the data from there rather than
> trying to build and populate a global mapping table.
> 
> Signed-off-by: Jesse Gross <jesse at kernel.org>

Good catch.

Acked-by: Ben Pfaff <blp at ovn.org>



More information about the dev mailing list