[ovs-dev] [PATCH 2/2] ofproto: Always set MTU for new internal ports.

Daniele Di Proietto diproiettod at vmware.com
Wed Aug 31 01:06:05 UTC 2016






On 30/08/2016 15:32, "Ben Pfaff" <blp at ovn.org> wrote:

>On Tue, Aug 30, 2016 at 11:41:15AM -0700, Daniele Di Proietto wrote:
>> We only changed the MTU of new internal ports if it is bigger than the
>> bridge minimum.  But when the minimum MTU of the bridge is updated we
>> change the MTU of all internal ports no matter what.
>> 
>> The behavior is inconsistent, because now the internal ports MTU depends
>> on the order in which the ports where added.
>> 
>> This commit fixes the problem by _always_ setting the MTU of new
>> internal ports to the bridge minimum.  I'm not sure what was the logic
>> behind only adjusting the mtu if it was too big.
>> 
>> A testcase is improved to detect the problem.
>> 
>> VMware-BZ: #1718776
>> Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
>
>Acked-by: Ben Pfaff <blp at ovn.org>

Thanks for the prompt reviews, I applied the series to master and branch-2.6


More information about the dev mailing list