[ovs-dev] [PATCH v2] ovn-controller: Remove unused members from local_datapath.

Ben Pfaff blp at ovn.org
Fri Dec 2 17:10:20 UTC 2016


On Thu, Dec 01, 2016 at 05:29:41PM -0800, Mickey Spiegel wrote:
> On Thu, Dec 1, 2016 at 4:34 PM, Ben Pfaff <blp at ovn.org> wrote:
> 
> > Nothing used these, except to initialize and free them.  'logical_port'
> > wasn't meaningful in any case, it was just the name of the first logical
> > port encountered from a particular logical datapath when traversing the
> > database's Port_Binding table, which isn't in a meaningful order.
> >
> 
> I have long considered the 'uuid' in local_datapath dangerous, due to
> the first logical port encountered issue that you mention. Since
> incremental processing disappeared, it has not been doing any harm.
> I agree that it is safer to remove it.
> 
> Acked-by: Mickey Spiegel <mickeys.dev at gmail.com>

Thanks.  I applied this to master.


More information about the dev mailing list