[ovs-dev] [PATCH] netdev-dpdk: Don't try to unregister empty vhost_id.

[Ilya Maximets]

On 02.12.2016 22:12, Daniele Di Proietto wrote:
> On 29/11/2016 05:26, "Loftus, Ciara" <ciara.loftus at intel.com> wrote:
>>> On 29.11.2016 15:20, Ilya Maximets wrote:
>>>> If 'vhost-server-path' not provided for vhostuserclient port,
>>>> 'netdev_dpdk_vhost_destruct()' will try to unregister an empty string.
>>>> This leads to error message in log:
>>>>
>>>> netdev_dpdk|ERR|vhost2: Unable to unregister vhost driver for socket ''.
>>>>
>>>> CC: Ciara Loftus <ciara.loftus at intel.com>
>>>> Fixes: 2d24d165d6a5 ("netdev-dpdk: Add new 'dpdkvhostuserclient' port
>>> type")
>>>> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
>>>> ---
>>>>  lib/netdev-dpdk.c | 5 +++++
>>>>  1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
>>>> index b51f329..6e5cd43 100644
>>>> --- a/lib/netdev-dpdk.c
>>>> +++ b/lib/netdev-dpdk.c
>>>> @@ -1027,6 +1027,10 @@ netdev_dpdk_vhost_destruct(struct netdev
>>> *netdev)
>>>>      ovs_mutex_unlock(&dev->mutex);
>>>>      ovs_mutex_unlock(&dpdk_mutex);
>>>>
>>>> +    if (!strlen(dev->vhost_id)) {
>>>
>>> Sorry,
>>> s/dev->vhost_id/vhost_id/
>>
>> LGTM.
>> Acked-by: Ciara Loftus <ciara.loftus at intel.com>
> 
> Thanks, pushed to master and branch-2.6

Looks like you've applied patch without the above fix.
I sent patch for that here:
https://mail.openvswitch.org/pipermail/ovs-dev/2016-December/325718.html

Best regards, Ilya Maximets.