[ovs-dev] [PATCH 4/5] datapath-windows: Fix function prototypes

Alin Serdean aserdean at cloudbasesolutions.com
Mon Dec 5 15:39:56 UTC 2016


There is a mismatch between OvsInitCompletionList and OvsAddPktCompletionList
prototypes.

Eg:
https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/PacketIO.h#L33
https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/PacketIO.c#L54

Found while compiling with Windows 10 kernel tool chain.

Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
---
 datapath-windows/ovsext/PacketIO.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/datapath-windows/ovsext/PacketIO.c b/datapath-windows/ovsext/PacketIO.c
index a0ddc3d..dacd6f9 100644
--- a/datapath-windows/ovsext/PacketIO.c
+++ b/datapath-windows/ovsext/PacketIO.c
@@ -51,7 +51,7 @@ static NTSTATUS OvsCreateNewNBLsFromMultipleNBs(
                     PNET_BUFFER_LIST *curNbl,
                     PNET_BUFFER_LIST *nextNbl);
 
-__inline VOID
+VOID
 OvsInitCompletionList(OvsCompletionList *completionList,
                       POVS_SWITCH_CONTEXT switchContext,
                       ULONG sendCompleteFlags)
@@ -64,7 +64,7 @@ OvsInitCompletionList(OvsCompletionList *completionList,
 }
 
 /* Utility function used to complete an NBL. */
-__inline VOID
+VOID
 OvsAddPktCompletionList(OvsCompletionList *completionList,
                         BOOLEAN incoming,
                         NDIS_SWITCH_PORT_ID sourcePort,
-- 
2.10.2.windows.1


More information about the dev mailing list