[ovs-dev] [PATCH 1/4] datapath-windows: Conntrack - Fix OvsGetTcpPayloadLength()

Alin Serdean aserdean at cloudbasesolutions.com
Mon Dec 5 16:02:46 UTC 2016


Thanks for the patch.

Looks good.

I was wondering if we could adapt and reuse OvsParseTcp (https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/PacketParser.c#L178) instead?

Thanks,
Alin.

> -----Original Message-----
> From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> bounces at openvswitch.org] On Behalf Of Sairam Venugopal
> Sent: Thursday, December 1, 2016 11:19 PM
> To: dev at openvswitch.org
> Subject: [ovs-dev] [PATCH 1/4] datapath-windows: Conntrack - Fix
> OvsGetTcpPayloadLength()
> 
> Move the OvsGetTcpPayloadLength() to common header. Update the code
> to check for null references and the correct size of the TCP header.
> 
> Signed-off-by: Sairam Venugopal <vsairam at vmware.com>
> ---
>  datapath-windows/ovsext/Conntrack-tcp.c | 15 ---------------
>  datapath-windows/ovsext/Conntrack.h     | 22 ++++++++++++++++++++++
>  2 files changed, 22 insertions(+), 15 deletions(-)
> 


More information about the dev mailing list