[ovs-dev] [PATCH] netdev-dpdk: Don't use dev->vhost_id without mutex.

Ben Pfaff blp at ovn.org
Mon Dec 5 16:32:38 UTC 2016


How about "if (!vhost_id[0])", to avoid a useless strlen call?

On Mon, Dec 05, 2016 at 09:14:27AM +0300, Ilya Maximets wrote:
> The copy should be used here.
> 
> Fixes: 821b86649a90 ("netdev-dpdk: Don't try to unregister empty vhost_id.")
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
> ---
>  lib/netdev-dpdk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index 6e5cd43..e06aa28 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -1027,7 +1027,7 @@ netdev_dpdk_vhost_destruct(struct netdev *netdev)
>      ovs_mutex_unlock(&dev->mutex);
>      ovs_mutex_unlock(&dpdk_mutex);
>  
> -    if (!strlen(dev->vhost_id)) {
> +    if (!strlen(vhost_id)) {
>          goto out;
>      }
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev


More information about the dev mailing list