[ovs-dev] [PATCH] ovn-controller(8): ovn-remote must be an IP adddress.

Ben Pfaff blp at ovn.org
Mon Dec 5 18:13:48 UTC 2016


On Mon, Dec 05, 2016 at 10:10:43AM -0800, Ben Pfaff wrote:
> On Mon, Dec 05, 2016 at 12:05:33PM -0500, Russell Bryant wrote:
> > Document that the value of the ovn-remote configuration
> > option must be an IP address.  This came up on IRC where
> > someone trying OVN put a hostname here and observed that
> > it did not work.
> > 
> > Signed-off-by: Russell Bryant <russell at ovn.org>
> > ---
> >  ovn/controller/ovn-controller.8.xml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-controller.8.xml
> > index 5f51cb1..825a538 100644
> > --- a/ovn/controller/ovn-controller.8.xml
> > +++ b/ovn/controller/ovn-controller.8.xml
> > @@ -93,7 +93,7 @@
> >        <dd>
> >          <p>
> >            The OVN database that this system should connect to for its
> > -          configuration.
> > +          configuration.  The value must be an IP address.
> >          </p>
> 
> Not an IP address but an OVSDB remote in the form tcp:ip[:port] or
> ssl:ip[:port].

Actually the documentation just below that paragraph is wrong too.

Maybe something like this:

diff --git a/ovn/controller/ovn-controller.8.xml b/ovn/controller/ovn-controller.8.xml
index 5f51cb1..9f4dad1 100644
--- a/ovn/controller/ovn-controller.8.xml
+++ b/ovn/controller/ovn-controller.8.xml
@@ -93,13 +93,8 @@
       <dd>
         <p>
           The OVN database that this system should connect to for its
-          configuration.
-        </p>
-
-        <p>
-          Currently, <code>ovn-controller</code> does not support changing this
-          setting mid-run.  If the value needs to change, the daemon must be
-          restarted.  (This behavior should be improved.)
+          configuration, in one of the same forms documented above for the
+          <var>ovs-database</var>.
         </p>
       </dd>
 


More information about the dev mailing list