[ovs-dev] [PATCH] datapath-windows: null comparison for icmp and tcp header

Alin Serdean aserdean at cloudbasesolutions.com
Mon Dec 5 20:19:22 UTC 2016


The problem is here:
https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Conntrack-tcp.c#L460

Looking back, it makes more sense to add them to OvsConntrackValidateIcmpPacket/OvsConntrackValidateTcpPacket.

Should I revert the original patch and send one that chages the functions mentioned above?

Thanks,
Alin.

> -----Original Message-----
> From: Sairam Venugopal [mailto:vsairam at vmware.com]
> Sent: Wednesday, November 30, 2016 8:15 PM
> To: Yin Lin <yinlin10 at gmail.com>; Alin Serdean
> <aserdean at cloudbasesolutions.com>
> Cc: dev at openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] datapath-windows: null comparison for icmp
> and tcp header
> 
> OvsConntrackValidateTcpPacket currently checks for NULL. I will update
> OvsConntrackValidateIcmpPacket to check for NULL as well.
> 
> 
> I acked this change to keep the checks consistent across different protocol.
> 
> Thanks,
> Sairam
> 
> 
> On 11/29/16, 2:30 PM, "Yin Lin" <yinlin10 at gmail.com> wrote:
> 
> >Can we decide if tcp and icmp is null in OvsConntrackValidateTcpPacket?
> >It makes the function more complete and safer by itself.
> >
> >On Mon, Nov 28, 2016 at 6:11 AM, Alin Serdean <
> >aserdean at cloudbasesolutions.com> wrote:
> >


More information about the dev mailing list