[ovs-dev] [PATCH v2] netdev-dpdk: Don't use dev->vhost_id without mutex.

Ilya Maximets i.maximets at samsung.com
Tue Dec 6 06:45:07 UTC 2016


The copy should be used here.
Additionally, 'strlen' changed to the faster check.

Fixes: 821b86649a90 ("netdev-dpdk: Don't try to unregister empty vhost_id.")
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
---
Version 2:
	* 'strlen' --> '[0]' (Suggested by Ben Pfaff)

 lib/netdev-dpdk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 6e5cd43..61d7aa3 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -1027,7 +1027,7 @@ netdev_dpdk_vhost_destruct(struct netdev *netdev)
     ovs_mutex_unlock(&dev->mutex);
     ovs_mutex_unlock(&dpdk_mutex);
 
-    if (!strlen(dev->vhost_id)) {
+    if (!vhost_id[0]) {
         goto out;
     }
 
-- 
2.7.4



More information about the dev mailing list