[ovs-dev] [PATCH 4/5] datapath-windows: Fix function prototypes

Sairam Venugopal vsairam at vmware.com
Thu Dec 8 23:10:55 UTC 2016


Acked-by: Sairam Venugopal <vsairam at vmware.com>


On 12/5/16, 7:39 AM, "Alin Serdean" <aserdean at cloudbasesolutions.com>
wrote:

>There is a mismatch between OvsInitCompletionList and
>OvsAddPktCompletionList
>prototypes.
>
>Eg:
>https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitc
>h_ovs_blob_master_datapath-2Dwindows_ovsext_PacketIO.h-23L33&d=DgICAg&c=ui
>laK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=8AKMs
>mfyRzn5xvNTQboqhDuunhZu4vYt4Vym0YI7-tM&s=oXXLPziBcet7PqVa02jDJwm_inXZOnYsK
>dX05_y0y-k&e= 
>https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitc
>h_ovs_blob_master_datapath-2Dwindows_ovsext_PacketIO.c-23L54&d=DgICAg&c=ui
>laK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=8AKMs
>mfyRzn5xvNTQboqhDuunhZu4vYt4Vym0YI7-tM&s=WR0V0caIZsNPr1lfeB0yOGiCCmNro5zYM
>Kwc_2T7ulM&e= 
>
>Found while compiling with Windows 10 kernel tool chain.
>
>Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
>---
> datapath-windows/ovsext/PacketIO.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/datapath-windows/ovsext/PacketIO.c
>b/datapath-windows/ovsext/PacketIO.c
>index a0ddc3d..dacd6f9 100644
>--- a/datapath-windows/ovsext/PacketIO.c
>+++ b/datapath-windows/ovsext/PacketIO.c
>@@ -51,7 +51,7 @@ static NTSTATUS OvsCreateNewNBLsFromMultipleNBs(
>                     PNET_BUFFER_LIST *curNbl,
>                     PNET_BUFFER_LIST *nextNbl);
> 
>-__inline VOID
>+VOID
> OvsInitCompletionList(OvsCompletionList *completionList,
>                       POVS_SWITCH_CONTEXT switchContext,
>                       ULONG sendCompleteFlags)
>@@ -64,7 +64,7 @@ OvsInitCompletionList(OvsCompletionList *completionList,
> }
> 
> /* Utility function used to complete an NBL. */
>-__inline VOID
>+VOID
> OvsAddPktCompletionList(OvsCompletionList *completionList,
>                         BOOLEAN incoming,
>                         NDIS_SWITCH_PORT_ID sourcePort,
>-- 
>2.10.2.windows.1
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_
>mailman_listinfo_ovs-2Ddev&d=DgICAg&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5
>ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=8AKMsmfyRzn5xvNTQboqhDuunhZu4vYt4Vym0YI
>7-tM&s=Cc5wG5_d5sRo9gUaBHqujGyhNXPkT-T_DD-DmqqLg8c&e= 



More information about the dev mailing list