[ovs-dev] [PATCH 2/3] ovn: Encode dhcpv6 PACKET_IN userdata as big endian.

[Daniele Di Proietto]

On 09/12/2016 05:44, "Numan Siddique" <nusiddiq at redhat.com> wrote:

>
>
>
>On Fri, Dec 9, 2016 at 8:20 AM, Daniele Di Proietto 
><diproiettod at vmware.com> wrote:
>
>The packet in userdata generated by ovn-controller when translating the
>put_dhcpv6_opt action includes 16-bit integers.
>
>Currently these 16-bit integers are encoded with native endianness.
>This is ok becase the only consumer of that userdata is ovn-controller
>itself, but it means that the OpenFlow action we're generating might
>not really be the same on different hosts.
>
>I think it's better to encode the userdata as big-endian, like the rest
>of OpenFlow messages.
>
>This fixes a test failure on big-endian platforms, because the generated
>OpenFlow bytes were different than expected (the expectation was
>generated on a little endian machine).
>
>Now 'struct dhcp_opt6_header' is identical to 'struct
>dhcpv6_opt_header', but I chose to keep them separate, because they
>have different purposes.  I also renamed the members to avoid confusion.
>
>I haven't tested this on a real setup.
>
>CC: Numan Siddique <nusiddiq at redhat.com>
>Reported-at: 
>https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=840770
>Signed-off-by <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=840770
>Signed-off-by>: Daniele Di Proietto <diproiettod at vmware.com>
>---
>
>
>
>
>
>
>​Thanks. I tested it and it works as expected.
>
>Acked-by: Numan Siddique <nusiddiq at redhat.com>

Thanks. I pushed this to master and branch-2.6