[ovs-dev] [PATCH 2/4] trivial: Consistently indent HTML with 2 spaces

Stephen Finucane stephen at that.guru
Wed Dec 14 18:27:13 UTC 2016


On Wed, 2016-12-14 at 10:06 -0800, Ben Pfaff wrote:
> On Wed, Dec 14, 2016 at 05:59:44PM +0000, Stephen Finucane wrote:
> > On Wed, 2016-12-14 at 09:46 -0800, Ben Pfaff wrote:
> > > On Wed, Dec 14, 2016 at 09:27:41AM -0800, Ben Pfaff wrote:
> > > > On Wed, Dec 14, 2016 at 10:10:08AM +0000, Stephen Finucane
> > > > wrote:
> > > > > On Tue, 2016-12-13 at 11:41 -0800, Ben Pfaff wrote:
> > > > > > On Tue, Dec 13, 2016 at 05:57:22PM +0000, Stephen Finucane
> > > > > > wrote:
> > > > > > > This will make upcoming changes easier to review.
> > > > > > > 
> > > > > > > Signed-off-by: Stephen Finucane <stephen at that.guru>
> > > > > > 
> > > > > > "git am" tells me:
> > > > > > 
> > > > > >     fatal: corrupt patch at line 397
> > > > > >     Patch failed at 0001 trivial: Consistently indent HTML
> > > > > > with
> > > > > > 2
> > > > > > spaces
> > > > > > 
> > > > > > Maybe a Github PR would work better, dunno.
> > > > > 
> > > > > I guess that warning I got about a line being greater than
> > > > > 998
> > > > > characters /wasn't/ safe to ignore :)
> > > > 
> > > > It is somewhat amusing that "git send-email" cleanly handles
> > > > binary
> > > > files, but not text files with long lines.
> > > > 
> > > > > You can find the PR at the link below - it still applies
> > > > > cleanly
> > > > > afaict:
> > > > > 
> > > > >   https://github.com/openvswitch/openvswitch.github.io/pull/2
> > > > > 8
> > > > 
> > > > I applied it.  Thanks!
> > > 
> > > This totally screwed up the design:
> > >         http://benpfaff.org/~blp/private/SS2lphsn/Screenshot%20-%
> > > 2012
> > > 142016%20-%2009:29:08%20AM.png
> > > so I un-applied it, but it didn't help.  I have no idea why the
> > > webpage is still broken.
> > 
> > I'm guessing that GitHub Pages' Jekyll system might not be able to
> > handle force pushes. I've just pushed another version with the fixe
> > (a
> > typo :() included. If you want to merge that, it should force the
> > rebuild.
> > 
> > Stephen
> > ('sfinucan' on freenode)
> 
> OK, I pushed it.

Still broken on my end, so I've submitted another PR:

  https://github.com/openvswitch/openvswitch.github.io/pull/32

I've no idea why it's happening, but GitHub appears to be substituting
our 'style.css' with one based on normalize.css. This change should
workaround this peculiarity until I can figure out what on earth is
happening.

Stephen


More information about the dev mailing list