[ovs-dev] [PATCH 0/8] port Jiri's 8 support patches for layer 3 encapsulated packets from net-next

Yang, Yi yi.y.yang at intel.com
Fri Dec 16 12:15:15 UTC 2016


On Thu, Dec 15, 2016 at 11:29:30PM -0800, Pravin Shelar wrote:
> On Thu, Dec 15, 2016 at 5:23 PM, Joe Stringer <joe at ovn.org> wrote:
> > On 15 December 2016 at 05:27, Yi Yang <yi.y.yang at intel.com> wrote:
> >> This patch set just ports Jiri's 8 support patches for layer 3 encapsulated packets from net-next to current ovs, this is a cornerstone for L3 tunnel port support in ovs.
> >
> > Please follow the directions for submitting patches:
> > http://docs.openvswitch.org/en/latest/internals/contributing/submitting-patches/
> >
> > In particular, I see a variety of complaints from the compiler with
> > this series, some of them may apply to upstream as well [I didn't get
> > as far as to check that yet], some are just warnings but we should
> > certainly fix them anyway; some are userspace compilation failures
> > with the newer headers.
> >
> > It would also provide further validation of the series if A) you can
> > point to a good full travis-ci run with this series; and B) if you
> > could run the kernel module testsuite to confirm things don't break. I
> > believe that Jarno had some pending patches for breakage introduced by
> > this series.
> >
> I agree, we need to sort out those issues upstream before merging it
> to out of tree kernel module.

Thank you all for pointing out these issues, I checked them, one warning
is from current ovs code, I'm not sue why your previous build didn't
find it, I will add a new patch to fix it.

Other build warnings are because we need 3 userspace patches from
Jiri's, I had thought they could be submitted in two patch series, I'll
resubmit this patch set with userspace patches included.

Yes, in net-next build, I saw build failure '"eth_type_vlan" redefined'
because new kernel header has this inline function but the old kernels
hasn't, renaming it to eth_type_is_vlan fixes build failure.

Now I have prepared new patch series, it can be built without any
warning, "make check" passed.

I'll try verification ways you mentioned.


More information about the dev mailing list