[ovs-dev] [PATCH v3 02/16] ovsdb-idl: Drop write-only member from struct ovsdb_idl_condition.
Ben Pfaff
blp at ovn.org
Sun Dec 18 08:18:20 UTC 2016
The 'tc' member of struct ovsdb_idl_condition was written but never read,
so remove it.
Signed-off-by: Ben Pfaff <blp at ovn.org>
---
lib/ovsdb-idl-provider.h | 1 -
lib/ovsdb-idl.c | 9 +++------
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/lib/ovsdb-idl-provider.h b/lib/ovsdb-idl-provider.h
index 3104f2c..1f5a49e 100644
--- a/lib/ovsdb-idl-provider.h
+++ b/lib/ovsdb-idl-provider.h
@@ -103,7 +103,6 @@ struct ovsdb_idl_table_class {
};
struct ovsdb_idl_condition {
- const struct ovsdb_idl_table_class *tc;
struct ovs_list clauses;
};
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 8ce228d..3974eb6 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -219,8 +219,7 @@ ovsdb_idl_table_from_class(const struct ovsdb_idl *,
const struct ovsdb_idl_table_class *);
static bool ovsdb_idl_track_is_set(struct ovsdb_idl_table *table);
static void ovsdb_idl_send_cond_change(struct ovsdb_idl *idl);
-static void ovsdb_idl_condition_init(struct ovsdb_idl_condition *cnd,
- const struct ovsdb_idl_table_class *tc);
+static void ovsdb_idl_condition_init(struct ovsdb_idl_condition *cnd);
/* Creates and returns a connection to database 'remote', which should be in a
* form acceptable to jsonrpc_session_open(). The connection will maintain an
@@ -279,7 +278,7 @@ ovsdb_idl_create(const char *remote, const struct ovsdb_idl_class *class,
= table->change_seqno[OVSDB_IDL_CHANGE_MODIFY]
= table->change_seqno[OVSDB_IDL_CHANGE_DELETE] = 0;
table->idl = idl;
- ovsdb_idl_condition_init(&table->condition, tc);
+ ovsdb_idl_condition_init(&table->condition);
table->cond_changed = false;
}
@@ -892,10 +891,8 @@ ovsdb_idl_condition_reset(struct ovsdb_idl *idl,
}
static void
-ovsdb_idl_condition_init(struct ovsdb_idl_condition *cnd,
- const struct ovsdb_idl_table_class *tc)
+ovsdb_idl_condition_init(struct ovsdb_idl_condition *cnd)
{
- cnd->tc = tc;
ovs_list_init(&cnd->clauses);
}
--
2.10.2
More information about the dev
mailing list