[ovs-dev] [PATCH v3 00/16] ovn: get rid of most uses of patch ports

[Mickey Spiegel]

On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff <blp at ovn.org> wrote:

> v1->v2:
>    - Fixed some bugs reported by Mickey throughout the series.
>    - Patches 1 and 2 are new.
>    - Patch 3 is modified in various ways, most notably to avoid using the
>    datapath "sample" action, to add a test, and to better conform to style
>    in a few small ways.
>
> v2->v3:
>    - Patch 5 is revised according to William's comments.
>    - Patch 13 incorporates a bug fix from Mickey.
>    - Patches 1 and 2 are new.
>    - Patches 14, 15, and 16 are new, and patch 16 now introduces
> conditional
>      monitoring.
>
> Ben Pfaff (15):
>   ovn-controller: Don't enable IDL tracking.
>   ovsdb-idl: Drop write-only member from struct ovsdb_idl_condition.
>   ofp-actions: Use struct ext_action_header for appropriate actions.
>   ofp-actions: Move function for struct ofpact_nest near struct
>     definition.
>   ovn-controller: Make indexes more broadly available.
>   lport: Be a little more careful building lport index.
>   lport: Tolerate null pointers in destroy functions.
>   lport: Add index for logical datapaths.
>   ovn-controller: Handle only relevant ports and flows.
>   pnysical: Factor code out of consider_port_binding().
>   ovn-controller: Avoid code duplication getting chassis record.
>   ovn-controller: Drop most uses of OVS patch ports.
>   ovn-controller: Rename all_lports to local_lports.
>   ovsdb-idl: Change interface to conditional monitoring.
>   ovn-controller: Monitor only necessary southbound rows.


> William Tu (1):
>   ofp-actions: Add clone action.
>

I reviewed 10 of the patches today.

I am not confident enough in my base OVS knowledge to
review 5 of the patches:
  ovn-controller: Don't enable IDL tracking.
  ofp-actions: Use struct ext_action_header for appropriate actions.
  ofp-actions: Move function for struct ofpact_nest near struct
    definition.
  ofp-actions: Add clone action.
  ovsdb-idl: Change interface to conditional monitoring.
Additional eyes on those patches would be a good thing.

I will review the last patch tomorrow morning when I am more coherent.

Mickey


>
>  include/openvswitch/ofp-actions.h |  17 +-
>  lib/ofp-actions.c                 | 185 +++++++++++++-------
>  lib/ovsdb-data.h                  |   1 +
>  lib/ovsdb-idl-provider.h          |   5 -
>  lib/ovsdb-idl.c                   | 220 +++++++++++++++---------
>  lib/ovsdb-idl.h                   |  29 +++-
>  ofproto/ofproto-dpif-xlate.c      |  14 ++
>  ovn/controller/binding.c          | 145 +++++++++++-----
>  ovn/controller/binding.h          |  11 +-
>  ovn/controller/chassis.c          |  12 +-
>  ovn/controller/chassis.h          |   3 +-
>  ovn/controller/lflow.c            |  46 +----
>  ovn/controller/lflow.h            |   1 -
>  ovn/controller/lport.c            |  82 +++++++++
>  ovn/controller/lport.h            |  33 +++-
>  ovn/controller/ovn-controller.c   | 142 ++++++++++------
>  ovn/controller/ovn-controller.h   |  33 ++--
>  ovn/controller/patch.c            | 110 ++----------
>  ovn/controller/patch.h            |   6 +-
>  ovn/controller/physical.c         | 343 ++++++++++++++++++++++--------
> --------
>  ovn/controller/physical.h         |   9 +-
>  ovn/controller/pinctrl.c          |  36 ++--
>  ovn/controller/pinctrl.h          |   4 +-
>  ovsdb/ovsdb-idlc.in               | 207 ++---------------------
>  python/ovs/db/idl.py              |  31 ++--
>  tests/ofp-actions.at              |   5 +
>  tests/ofproto-dpif.at             |  18 ++
>  tests/ovn-controller.at           |  50 +-----
>  tests/ovn.at                      |   4 +-
>  tests/ovsdb-idl.at                |  30 ++--
>  tests/system-traffic.at           |  29 ++++
>  tests/test-ovsdb.c                | 208 +++++++----------------
>  tests/test-ovsdb.py               |  16 +-
>  33 files changed, 1069 insertions(+), 1016 deletions(-)
>
> --
> 2.10.2
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>