[ovs-dev] [PATCH 1/3] ovsdb-idl: Avoid sending redundant conditional monitoring updates

Andy Zhou azhou at ovn.org
Tue Dec 20 09:47:15 UTC 2016


In case connection is reset when there are buffered but unsent
conditions, these conditions will be sent as the new "monitor_cond"
message that will be sent after the idl reconnects.

Without this patch, those conditions will be unnecessarily sent again
with following monitoring condition update message.

Signed-off-by: Andy Zhou <azhou at ovn.org>
---
 lib/ovsdb-idl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 1be1c68..218b6b3 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -345,6 +345,7 @@ ovsdb_idl_clear(struct ovsdb_idl *idl)
         struct ovsdb_idl_table *table = &idl->tables[i];
         struct ovsdb_idl_row *row, *next_row;
 
+        table->cond_changed = false;
         if (hmap_is_empty(&table->rows)) {
             continue;
         }
@@ -370,6 +371,7 @@ ovsdb_idl_clear(struct ovsdb_idl *idl)
         }
     }
 
+    idl->cond_changed = false;
     ovsdb_idl_track_clear(idl);
 
     if (changed) {
-- 
1.9.1



More information about the dev mailing list