[ovs-dev] [PATCH] ovn-controller: Fix conntrack zone in gateway routers.

Ben Pfaff blp at ovn.org
Tue Dec 20 22:45:34 UTC 2016


On Tue, Dec 20, 2016 at 08:21:28AM -0800, Guru Shetty wrote:
> On 19 December 2016 at 21:26, Ben Pfaff <blp at ovn.org> wrote:
> > > -    ct->zone_src.field = mf_from_id(MFF_LOG_CT_ZONE);
> > > +    ct->zone_src.field = ep->is_switch ? mf_from_id(MFF_LOG_CT_ZONE)
> > > +                            : mf_from_id(MFF_LOG_DNAT_ZONE);
> >
> > You could put the ?: inside the mf_from_id().
> >
> There were a few other places using the above style. So I let it be (I
> hope there was no inherent advantage with one style over the other here?)

The two forms are only syntactically different.


More information about the dev mailing list