[ovs-dev] [PATCH] ovs-vsctl: Print error when add-port fails.

Daniele Di Proietto diproiettod at vmware.com
Wed Dec 21 19:21:19 UTC 2016






On 20/12/2016 21:37, "Ben Pfaff" <blp at ovn.org> wrote:

>On Tue, Dec 20, 2016 at 06:49:24PM -0800, Daniele Di Proietto wrote:
>> When the add-port command fails, vsctl reports the failure and just
>> suggests to check the logs for more details.
>> 
>> ovs-vswitchd fills the error column in the Interface table with a
>> description of the error, so it might be helpful to print that.
>> 
>> This is useful especially for dpdk devices, because the port naming
>> change could use a better error reporting.
>> 
>> I'm planning another patch to make sure that ovs-vswitch writes
>> appropriates information in the error column, after the dpdk port naming
>> changes are merged.
>> 
>> CC: Ben Pfaff <blp at ovn.org>
>> Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
>
>I have another idea for improving the output here.  Quite often, when
>someone posts an error, they haven't looked in the log, even though they
>quoted the error message recommending that.  Then, when I ask them to
>look in the log, the next question is always "where's the log?"  So,
>what if we added something like "The default log directory is %s.",
>where %s is ovs_logdir(), to the error message?  Perhaps it will help at
>least one person find the log.

Good idea, I've added that

>
>Acked-by: Ben Pfaff <blp at ovn.org>

Thanks, I pushed this to master


More information about the dev mailing list