[ovs-dev] [PATCH 2/3] ovsdb-idl: Properly handle conditional monitor update error

Ben Pfaff blp at ovn.org
Thu Dec 22 17:21:43 UTC 2016

On Tue, Dec 20, 2016 at 01:47:16AM -0800, Andy Zhou wrote:
> From: andy zhou <azhou at ovn.org>
> When generating conditional monitoring update request, current code
> failed to update idl's 'request-id'.  This bug causes the reply
> message of the update request, regardless an ACK or a NACK, be
> logged as an unexpected message at the debug level and ignored by
> the core idl logic.
> In addition, the idl should not generate another conditional
> monitoring update request when there is an outstanding request.
> So that the requests and their reply are properly serialized.
> When the conditional monitoring is nacked by the server, drop idl
> into a client visible error state.
> Signed-off-by: Andy Zhou <azhou at ovn.org>

When the condition is changed when an update request is already in
flight, and the update request completes, will the code properly send
a new condition change at that point?

More information about the dev mailing list