[ovs-dev] [PATCH v2 1/2] sflow: restrict sampling from 1 to UINT32_MAX

Benli Ye daniely at vmware.com
Fri Dec 23 05:58:00 UTC 2016


When sampling field is 0, no need to generate sample or
the inner action.

Signed-off-by: Benli Ye <daniely at vmware.com>
---
 ofproto/ofproto-dpif-xlate.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
index 08a72a7..3eb94ac 100644
--- a/ofproto/ofproto-dpif-xlate.c
+++ b/ofproto/ofproto-dpif-xlate.c
@@ -2506,6 +2506,11 @@ compose_sample_action(struct xlate_ctx *ctx,
                       const odp_port_t tunnel_out_port,
                       bool include_actions)
 {
+    if (probability == 0) {
+        /* No need to generate sampling or the inner action. */
+        return 0;
+    }
+
     size_t sample_offset = nl_msg_start_nested(ctx->odp_actions,
                                                OVS_ACTION_ATTR_SAMPLE);
 
-- 
1.9.1



More information about the dev mailing list