[ovs-dev] [PATCH] ofproto-dpif-xlate: Adding IGMP/MLD checksum verification

Ben Pfaff blp at ovn.org
Fri Dec 23 17:07:48 UTC 2016


On Fri, Dec 23, 2016 at 10:31:19AM +0100, Eelco Chaudron wrote:
> On 22/12/16 17:14, Ben Pfaff wrote:
> >On Wed, Dec 14, 2016 at 07:08:27PM +0100, Eelco Chaudron wrote:
> >>When IGMP or MLD packets arrive their content is used without the checksum
> >>being verified. With this change the checksum is verified, and the packet
> >>is not used for multicast snooping on failure.
> >>
> >>Signed-off-by: Eelco Chaudron <echaudro at redhat.com>
> >Thanks for the patch!  I applied it to master.  I folded in the
> >following simplification, which I believe to be correct and also passes
> >the test.  Please let me know if you see a problem.
> Thanks, your change is fine. I just mimicked the code above my change.

Oh, I hadn't noticed that.  I think it's best to adjust that code too.
I sent out a patch for review.

> >Also, I believe that this is your first contribution to Open vSwitch.
> >Thank you for helping, and welcome to the team!
> Yes this is my first patch, but I'm planning on doing a lot more next year!

Great!


More information about the dev mailing list