[ovs-dev] [PATCH] rconn: Avoid abort for ill-behaved remote.

Ben Pfaff blp at ovn.org
Fri Dec 23 21:31:05 UTC 2016


On Fri, Dec 23, 2016 at 01:02:00PM -0800, Justin Pettit wrote:
> 
> > On Dec 23, 2016, at 9:23 AM, Ben Pfaff <blp at ovn.org> wrote:
> > 
> > If an rconn peer fails to send a hello message, the version number doesn't
> > get set.  Later, if the peer delays long enough, the rconn attempts to send
> > an echo request but assert-fails instead because it doesn't know what
> > version to use.  This fixes the problem.
> > 
> > To reproduce this problem:
> > 
> >    make sandbox
> >    ovs-vsctl add-br br0
> >    ovs-vsctl set-controller br0 ptcp:12345
> >    nc 127.0.0.1 12345
> > 
> > and wait 10 seconds for ovs-vswitchd to die.  (Then exit the sandbox.)
> > 
> > Reported-by: 张东亚 <fortitude.zhang at gmail.com>
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> 
> Acked-by: Justin Pettit <jpettit at ovn.org>

Thanks.  I applied this to master and backported it as far as
branch-2.0.


More information about the dev mailing list