[ovs-dev] [PATCH 4/5] Python tests: Set CREATE_NO_WINDOW flag for Popen

Alin Serdean aserdean at cloudbasesolutions.com
Thu Dec 29 22:28:35 UTC 2016


Just one question: are the modifications to Xen Server necessarry?

Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions>
Tested-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions>

> -----Original Message-----
> From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> bounces at openvswitch.org] On Behalf Of Alin Balutoiu
> Sent: Thursday, December 29, 2016 7:41 PM
> To: dev at openvswitch.org
> Cc: Alin Balutoiu <abalutoiu at cloudbasesolutions.com>
> Subject: [ovs-dev] [PATCH 4/5] Python tests: Set CREATE_NO_WINDOW flag
> for Popen
> 
> On Windows if the flag CREATE_NO_WINDOW is not specified when using
> subprocess.Popen, a new window will appear with the new process.
> 
> The window is not necessary for the tests.
> This patch addresses this issue by adding the flag CREATE_NO_WINDOW for
> all subprocess.Popen calls if the machine is running Windows.
> 
> Signed-off-by: Alin-Gheorghe Balutoiu <abalutoiu at cloudbasesolutions.com>
> ---
>  ovn/utilities/ovn-docker-overlay-driver                     |  7 ++++++-
>  ovn/utilities/ovn-docker-underlay-driver                    |  7 ++++++-
>  python/ovstest/util.py                                      | 13 +++++++++++--
>  utilities/bugtool/ovs-bugtool.in                            | 12 ++++++++++--
>  utilities/ovs-dev.py                                        |  6 +++++-
>  utilities/ovs-dpctl-top.in                                  |  6 +++++-
>  utilities/ovs-parse-backtrace.in                            |  6 +++++-
>  utilities/ovs-tcpdump.in                                    |  5 ++++-
>  vtep/ovs-vtep                                               |  6 +++++-
>  xenserver/etc_xapi.d_plugins_openvswitch-cfg-update         |  7 ++++++-
>  .../opt_xensource_libexec_InterfaceReconfigureVswitch.py    |  7 ++++++-
>  xenserver/opt_xensource_libexec_interface-reconfigure       |  6 +++++-
>  12 files changed, 74 insertions(+), 14 deletions(-)
> 


More information about the dev mailing list