[ovs-dev] [PATCH 0/5] Adds python tests support for Windows

[Alin Serdean]

Thanks a lot for the series!

I don't think I make a good Python reviewer and I encourage any other reviewer to look over it.

Implementation looks good and all of the unit tests are working.

Adding this series to ovs_lib allows Neutron ML2 native implemention to work under Windows.

Thanks for incorporating my comments prior sending them to the mailing list :) (it's the first time I review your code offline).

Alin.

> -----Original Message-----
> From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-
> bounces at openvswitch.org] On Behalf Of Alin Balutoiu
> Sent: Thursday, December 29, 2016 7:41 PM
> To: dev at openvswitch.org
> Cc: Alin Balutoiu <abalutoiu at cloudbasesolutions.com>
> Subject: [ovs-dev] [PATCH 0/5] Adds python tests support for Windows
> 
> This series of patches ports python daemon and unixctl to Windows.
> All patches depend on each other.
> 
> The the daemon was ported using the Win32 API available in the python
> library pypiwin32. Unixctl was ported using named-pipes in order to be
> compatible with OVS Windows applications.
> 
> An additional flag (CREATE_NO_WINDOW) is also added to
> subprocess.Popen for Windows. The console window is not used in any way,
> therefore we can disable the console window for processes created on
> Windows.
> 
> 
> Alin Balutoiu (5):
>   Python tests: Add winutils.py module
>   Python tests: Ported UNIX sockets to Windows
>   Python tests: Daemon ported to Windows
>   Python tests: Set CREATE_NO_WINDOW flag for Popen
>   Python tests: Enable python tests on Windows
> 
>  Documentation/intro/install/windows.rst            |   7 +
>  ovn/utilities/ovn-docker-overlay-driver            |   7 +-
>  ovn/utilities/ovn-docker-underlay-driver           |   7 +-
>  python/automake.mk                                 |   3 +-
>  python/ovs/daemon.py                               | 194 ++++++++++--
>  python/ovs/fatal_signal.py                         |  13 +
>  python/ovs/jsonrpc.py                              |   6 +
>  python/ovs/poller.py                               |  72 +++--
>  python/ovs/socket_util.py                          |  31 +-
>  python/ovs/stream.py                               | 351 ++++++++++++++++++++-
>  python/ovs/unixctl/server.py                       |   4 +
>  python/ovs/vlog.py                                 |  26 +-
>  python/ovs/winutils.py                             | 226 +++++++++++++
>  python/ovstest/util.py                             |  13 +-
>  tests/atlocal.in                                   |   8 -
>  tests/test-daemon.py                               |   4 +-
>  tests/test-jsonrpc.py                              |  16 +-
>  utilities/bugtool/ovs-bugtool.in                   |  12 +-
>  utilities/ovs-dev.py                               |   6 +-
>  utilities/ovs-dpctl-top.in                         |   6 +-
>  utilities/ovs-parse-backtrace.in                   |   6 +-
>  utilities/ovs-tcpdump.in                           |   5 +-
>  vtep/ovs-vtep                                      |   6 +-
>  .../etc_xapi.d_plugins_openvswitch-cfg-update      |   7 +-
>  ...ensource_libexec_InterfaceReconfigureVswitch.py |   7 +-
>  .../opt_xensource_libexec_interface-reconfigure    |   6 +-
>  26 files changed, 944 insertions(+), 105 deletions(-)  create mode 100644
> python/ovs/winutils.py
> 
> --
> 2.10.0.windows.1
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev