[ovs-dev] [PATCH] ovn-northd: Don't set custon log level defaults.

[Kyle Mestery]

On Mon, Feb 1, 2016 at 9:01 AM, Russell Bryant <russell at ovn.org> wrote:
> ovn-northd set some custom log level defaults, which I believe were
> copied from ovs-vsctl.  Other daemons don't set this.  The difference in
> behavior in ovn-northd vs other daemons has caused some confusion during
> OpenStack+OVN development and testing, so make it consistent.
>
> Reported-by: Ryan Moats <rmoats at us.ibm.com>
> Reported-at: https://bugs.launchpad.net/bugs/1539994
> Signed-off-by: Russell Bryant <russell at ovn.org>
> ---
>  ovn/northd/ovn-northd.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
> index 4f03287..8083e25 100644
> --- a/ovn/northd/ovn-northd.c
> +++ b/ovn/northd/ovn-northd.c
> @@ -1877,7 +1877,6 @@ add_column_noalert(struct ovsdb_idl *idl,
>  int
>  main(int argc, char *argv[])
>  {
> -    extern struct vlog_module VLM_reconnect;
>      unsigned int ovnnb_seqno, ovnsb_seqno;
>      int res = EXIT_SUCCESS;
>      struct unixctl_server *unixctl;
> @@ -1887,8 +1886,6 @@ main(int argc, char *argv[])
>      fatal_ignore_sigpipe();
>      set_program_name(argv[0]);
>      service_start(&argc, &argv);
> -    vlog_set_levels(NULL, VLF_CONSOLE, VLL_WARN);
> -    vlog_set_levels(&VLM_reconnect, VLF_ANY_DESTINATION, VLL_WARN);
>      parse_options(argc, argv);
>
>      daemonize_start(false);
> --
> 2.5.0
>
Minor nit in the spelling of "custom" in the subject, but otherwise:

Acked-By: Kyle Mestery <mestery at mestery.com>

> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev