[ovs-dev] [emc processing optimization v2 (rebase) 1/2] dpif-netdev: Load packet pointer only once in emc_processing()

Andy Zhou azhou at ovn.org
Tue Feb 2 20:04:38 UTC 2016


On Mon, Feb 1, 2016 at 7:00 PM, Daniele Di Proietto <diproiettod at vmware.com>
wrote:

>
>
> On 01/02/2016 12:46, "Andy Zhou" <azhou at ovn.org> wrote:
>
> >For the machines I have access to, Reloading the same pointer from
> >memory seems to inhibit complier optimization somewhat.
> >
> >In emc_processing(), using a single packet pointer, instead reloading
> >it from memory with packets[i], improves performance by 0.3 Mpps (tested
> >with 10G NIC pushing 64 byte packets, with the base line of 12.2 Mpps).
> >
> >Besides improving performance, this patch should also improves code
> >readability.
>
> Nice :-)
>
> >Signed-off-by: Andy Zhou <azhou at ovn.org>
>
> Acked-by: Daniele Di Proietto <diproiettod at vmware.com>
>
> One minor nit below
>
That got introduced during rebase.  Fixed and pushed to master.  Thanks.



More information about the dev mailing list