[ovs-dev] [PATCH] flake8: Fix use of --select and --ignore.

Ben Pfaff blp at ovn.org
Tue Feb 2 21:30:56 UTC 2016


On Fri, Jan 22, 2016 at 02:53:13PM -0500, Russell Bryant wrote:
> The flake8 command evolved over a series of patches and now includes the
> use of both --select and --ignore.  Unfortunately, this wasn't doing
> what I thought.  The use of --select completely overrides what --ignore
> does, meaning that we were only currently enforcing a small number of
> warnings specified in --select.  This patch runs flake8 twice, once with
> --select and once with --ignore to actually enforce the full desired
> set of warnings.
> 
> No additional violations had been introduced, but I noticed this while
> working on some other patches.
> 
> Signed-off-by: Russell Bryant <russell at ovn.org>

Interesting.

Acked-by: Ben Pfaff <blp at ovn.org>



More information about the dev mailing list