[ovs-dev] [PATCH v2 3/6] vlog: Stop using explicit references to external log modules.

[Ben Pfaff]

On Wed, Feb 03, 2016 at 05:07:36PM -0500, Russell Bryant wrote:
> On 02/03/2016 04:50 PM, Ben Pfaff wrote:
> > It's always risky to write "extern" declarations outside a header file,
> > since there's no way to ensure the type of what's being referenced is
> > correct.  In these cases, we can easily avoid the extern reference, so do
> > so.
> > 
> > There is a little tradeoff here, in that referring to the log modules
> > through strings means that we catch an incorrect module name at runtime
> > instead of at link time, but I think that the risk here is minimal because
> > the mistake will be found by every test in "make check" that runs any of
> > the utilities, since they make these calls as one of their first tasks
> > during initialization.
> > 
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> 
> Acked-by: Russell Bryant <russell at ovn.org>

Thanks for the reviews.  I applied patches 1, 2, and 3 to master.