[ovs-dev] [PATCH branch-2.3 v2 5/5] ofproto-dpif-upcall: Do not attribute stats when flow_del returns error.

Ben Pfaff blp at ovn.org
Fri Feb 5 18:32:09 UTC 2016


On Thu, Feb 04, 2016 at 04:10:11PM -0800, Jarno Rajahalme wrote:
> From: Alex Wang <ee07b291 at gmail.com>
> 
> In the push_dump_ops__(), when flow_del operation returns error, the 'struct
> stats' passed to the operation function will be set to all zero.  And we
> should not use it to calculate the delta (i.e. minus the zero stats by the
> cached stats causes overflow).
> 
> Even though this should rarely happen, it is still good to make
> push_ukey_ops__() just ignore the operation when it fails.
> 
> This is a backport of commit e83c935 to branch-2.3.
> 
> Signed-off-by: Alex Wang <ee07b291 at gmail.com>
> Acked-by: Daniele Di Proietto <diproiettod at vmware.com>
> Signed-off-by: Jarno Rajahalme <jarno at ovn.org>

This looks harmless at worst, to me.



More information about the dev mailing list